[media] v4l: make sure drivers supply a zeroed struct v4l2_subdev
authorHerton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
Fri, 1 Apr 2011 17:12:02 +0000 (14:12 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Fri, 29 Apr 2011 15:33:28 +0000 (12:33 -0300)
commit80845a33165278f3236812009e9c568ba8c29938
treefdf785e3a5ca7cd6cf26a4e1d19b3928b96bbcae
parent2b5cb549f8a31b44575fe25ccd043ddb7e901cf8
[media] v4l: make sure drivers supply a zeroed struct v4l2_subdev

Some v4l drivers currently don't initialize their struct v4l2_subdev
with zeros, and this is a problem since some of the v4l2 code expects
this. One example is the addition of internal_ops in commit 45f6f84,
after that we are at risk of random oopses with these drivers when code
in v4l2_device_register_subdev tries to dereference sd->internal_ops->*,
as can be shown by the report at http://bugs.launchpad.net/bugs/745213
and analysis of its crash at https://lkml.org/lkml/2011/4/1/168

Use kzalloc within problematic drivers to ensure we have a zeroed struct
v4l2_subdev.

BugLink: http://bugs.launchpad.net/bugs/745213
Cc: <stable@kernel.org>
Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/radio/saa7706h.c
drivers/media/radio/tef6862.c
drivers/media/video/m52790.c
drivers/media/video/tda9840.c
drivers/media/video/tea6415c.c
drivers/media/video/tea6420.c
drivers/media/video/upd64031a.c
drivers/media/video/upd64083.c