[media] uvcvideo: Fix integer overflow in uvc_ioctl_ctrl_map()
authorHaogang Chen <haogangchen@gmail.com>
Tue, 29 Nov 2011 21:32:25 +0000 (18:32 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Sun, 11 Dec 2011 13:23:54 +0000 (11:23 -0200)
commit806e23e95f94a27ee445022d724060b9b45cb64a
tree785b64a9a8b6fe3e64414760dd8229fb171563a6
parent66847ef013cc4ed3ae519360e7e4cbf531465ae8
[media] uvcvideo: Fix integer overflow in uvc_ioctl_ctrl_map()

There is a potential integer overflow in uvc_ioctl_ctrl_map(). When a
large xmap->menu_count is passed from the userspace, the subsequent call
to kmalloc() will allocate a buffer smaller than expected.
map->menu_count and map->menu_info would later be used in a loop (e.g.
in uvc_query_v4l2_ctrl), which leads to out-of-bound access.

The patch checks the ioctl argument and returns -EINVAL for zero or too
large values in xmap->menu_count.

Signed-off-by: Haogang Chen <haogangchen@gmail.com>
[laurent.pinchart@ideasonboard.com Prevent excessive memory consumption]
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: stable@kernel.org
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/uvc/uvc_v4l2.c
drivers/media/video/uvc/uvcvideo.h