nfsd: fix file access refcount leak when nfsd4_truncate fails
authorChristoph Hellwig <hch@infradead.org>
Mon, 30 Jun 2014 15:48:30 +0000 (11:48 -0400)
committerJ. Bruce Fields <bfields@redhat.com>
Tue, 8 Jul 2014 21:14:29 +0000 (17:14 -0400)
commit7e6a72e5f1d42768a9949d73d3337277ff96e026
tree934632aa5d8d84374a927ddf1855dee9d5c58485
parent1055414fe19db2db6c8947c0b9ee9c8fe07beea1
nfsd: fix file access refcount leak when nfsd4_truncate fails

nfsd4_process_open2 will currently will get access to the file, and then
call nfsd4_truncate to (possibly) truncate it. If that operation fails
though, then the access references will never be released as the
nfs4_ol_stateid is never initialized.

Fix by moving the nfsd4_truncate call into nfs4_get_vfs_file, ensuring
that the refcounts are properly put if the truncate fails.

Signed-off-by: Jeff Layton <jlayton@primarydata.com>
Signed-off-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfs4state.c