projects / GitHub / MotorolaMobilityLLC / kernel-slsi.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 4161824) | patch
uprobes/tracing: Ensure inode != NULL in create_trace_uprobe()
authorOleg Nesterov <oleg@redhat.com>
Mon, 28 Jan 2013 16:08:47 +0000 (17:08 +0100)
committerOleg Nesterov <oleg@redhat.com>
Fri, 8 Feb 2013 17:24:14 +0000 (18:24 +0100)
commit7e4e28c53963e6cfa94d8109bb8f5233c5659048
tree5405bc0552ef0f2d8c67bb9ef6b391f5a7a504b3tree | snapshot (tar.gz zip)
parent4161824f18ff4f56f46595a4016c7315dd0d24f1commit | diff
uprobes/tracing: Ensure inode != NULL in create_trace_uprobe()

probe_event_enable/disable() check tu->inode != NULL at the start.
This is ugly, if igrab() can fail create_trace_uprobe() should not
succeed and "postpone" the failure.

And S_ISREG(inode->i_mode) check added by d24d7dbf is not safe.

Note: alloc_uprobe() should probably check igrab() != NULL as well.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
kernel/trace/trace_uprobe.c diff | blob | blame | history
Motorola kernel-slsi