target: Fix max_cmd_sn increment w/o cmdsn mutex regressions
authorRoland Dreier <roland@purestorage.com>
Tue, 8 Sep 2015 13:14:18 +0000 (06:14 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Fri, 11 Sep 2015 07:32:28 +0000 (00:32 -0700)
commit7dd03aca9d61a9b64cd2a8cf6f5ea6f1f5391e8d
tree9dec30b18f9ec4626dd9c17bc99bb134726f80e4
parent4416f89b8cfcb794d040fc3b68e5fb159b7d8d02
target: Fix max_cmd_sn increment w/o cmdsn mutex regressions

Current for-next iscsi target is broken:

commit 109e2381749c1cfd94a0d22b2b54142539024973
Author: Roland Dreier <roland@purestorage.com>
Date:   Thu Jul 23 14:53:32 2015 -0700

    target: Drop iSCSI use of mutex around max_cmd_sn increment

This patch fixes incorrect pr_debug() + atomic_inc_return() usage
within iscsit_increment_maxcmdsn() code.

Also fix funny iscsit_determine_maxcmdsn() usage and update
iscsi_target_do_tx_login_io() code.

Reported-by: Sagi Grimberg <sagig@mellanox.com>
Cc: Sagi Grimberg <sagig@mellanox.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
Cc: Roland Dreier <roland@purestorage.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/iscsi/iscsi_target_device.c
drivers/target/iscsi/iscsi_target_nego.c