ipv4: provide stronger user input validation in nl_fib_input()
authorEric Dumazet <edumazet@google.com>
Wed, 22 Mar 2017 02:22:28 +0000 (19:22 -0700)
committerWilly Tarreau <w@1wt.eu>
Tue, 20 Jun 2017 12:04:35 +0000 (14:04 +0200)
commit7dbfa253c3832f4107ce019d026c7892b7d7ec1a
treef0728d38f96a62f0a54269182252f99112dc7617
parent6e37a689238c8bbb5e1de45588a00aa716967089
ipv4: provide stronger user input validation in nl_fib_input()

commit c64c0b3cac4c5b8cb093727d2c19743ea3965c0b upstream.

Alexander reported a KMSAN splat caused by reads of uninitialized
field (tb_id_in) from user provided struct fib_result_nl

It turns out nl_fib_input() sanity tests on user input is a bit
wrong :

User can pretend nlh->nlmsg_len is big enough, but provide
at sendmsg() time a too small buffer.

Reported-by: Alexander Potapenko <glider@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
net/ipv4/fib_frontend.c