staging: octeon: Fix logic for waking octeon ethernet tx queue.
authorLuuk Paulussen <luuk.paulussen@alliedtelesis.co.nz>
Tue, 22 Dec 2015 20:51:14 +0000 (09:51 +1300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 8 Feb 2016 03:35:16 +0000 (19:35 -0800)
commit7c0b6bce6e848a59cd15d1ade9db346d34d90c5a
treeda554734918860448c2a8f0092a334146ea8728f
parent5a89a875c96a9d038715c42f5f712002ce5124d0
staging: octeon: Fix logic for waking octeon ethernet tx queue.

Only wake tx queue when driver queue is back within bounds.

The logic here was just reenabling the queue when any buffers had been
freed.  the queue was stopped whenever the length exceeded 1000
(MAX_OUT_QUEUE_DEPTH), but then was essentially immediately started again.
On a congested link, the queue length would just keep increasing up to
around 8000 (for average size packets), at which point the hardware would
start refusing the packets and they would begin to be dropped.
This prevented the qdisc layer from effectively managing and prioritising
packets, as essentially all packets were being allowed into the driver
queue and then were being dropped by the hardware.

This change only restarts the queue if the length is less than 1000
(MAX_OUT_QUEUE_DEPTH).

Reviewed-by: Kyeong Yoo <kyeong.yoo@alliedtelesis.co.nz>
Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Reviewed-by: Richard Laing <richard.laing@alliedtelesis.co.nz>
Signed-off-by: Luuk Paulussen <luuk.paulussen@alliedtelesis.co.nz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/octeon/ethernet-tx.c