ASoC: mxs: Fix error handling in mxs_sgtl5000_probe
authorMiaoqian Lin <linmq006@gmail.com>
Tue, 8 Mar 2022 02:01:44 +0000 (02:01 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Apr 2022 07:08:16 +0000 (09:08 +0200)
commit790d2628e3fcc819d8f5572eb5615113fb2e727a
treeebec08d7d43b616d966ba4560ee92bd432f931b5
parente49f0cedf12135893aad216253738fdcf9125170
ASoC: mxs: Fix error handling in mxs_sgtl5000_probe

[ Upstream commit 6ae0a4d8fec551ec581d620f0eb1fe31f755551c ]

This function only calls of_node_put() in the regular path.
And it will cause refcount leak in error paths.
For example, when codec_np is NULL, saif_np[0] and saif_np[1]
are not NULL, it will cause leaks.

of_node_put() will check if the node pointer is NULL, so we can
call it directly to release the refcount of regular pointers.

Fixes: e968194b45c4 ("ASoC: mxs: add device tree support for mxs-sgtl5000")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220308020146.26496-1-linmq006@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/mxs/mxs-sgtl5000.c