drivers: net: ethernet: ti: davinci_emac: fix usage of cpdma_check_free_tx_desc()
authorMugunthan V N <mugunthanvnm@ti.com>
Fri, 15 Mar 2013 04:10:16 +0000 (04:10 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 17 Mar 2013 16:18:44 +0000 (12:18 -0400)
commit75b9b61bb8a18e75afe7b10dd55681e748fa27df
tree2694727c1c95e26ff9f471d5f986baec8fef541b
parentdb0b82760ef84562b5c0fa880c22b4f352545554
drivers: net: ethernet: ti: davinci_emac: fix usage of cpdma_check_free_tx_desc()

Fix which was done in the following commit in cpsw driver has
to be taken forward to davinci emac driver as well.

commit d35162f89b8f00537d7b240b76d2d0e8b8d29aa0
Author: Daniel Mack <zonque@gmail.com>
Date:   Tue Mar 12 06:31:19 2013 +0000

    net: ethernet: cpsw: fix usage of cpdma_check_free_tx_desc()

    Commit fae50823d0 ("net: ethernet: davinci_cpdma: Add boundary for rx
    and tx descriptors") introduced a function to check the current
    allocation state of tx packets. The return value is taken into account
    to stop the netqork queue on the adapter in case there are no free
    slots.

    However, cpdma_check_free_tx_desc() returns 'true' if there is room in
    the bitmap, not 'false', so the usage of the function is wrong.

Reported-by: Prabhakar Lad <prabhakar.csengg@gmail.com>
Tested-by: Prabhakar Lad <prabhakar.csengg@gmail.com>
Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ti/davinci_emac.c