RTC: Avoid races between RTC alarm wakeup and suspend.
authorNeilBrown <neilb@suse.de>
Sun, 5 Aug 2012 20:56:20 +0000 (22:56 +0200)
committerRafael J. Wysocki <rjw@sisk.pl>
Wed, 8 Aug 2012 18:49:16 +0000 (20:49 +0200)
commit7523ceed42d84c1afaa1dc498bffed53c2aa444e
tree3da6d7ea253851657b49413001c8512871a86f96
parent0d7614f09c1ebdbaa1599a5aba7593f147bf96ee
RTC: Avoid races between RTC alarm wakeup and suspend.

If an RTC alarm fires just as suspend is happening, it is possible for
suspend to complete and the alarm to be missed.

To avoid the race, we must register the event with the PM core.

As the event is made visible to userspace through a thread which is
only scheduled by the interrupt, we need a pm_stay_awake/pm_relax
pair preventing suspend from the interrupt until the thread completes
its work.

This makes the pm_wakeup_event() call in cmos_interrupt unnecessary as
it provides suspend protection for all RTCs that use rtc_update_irq.

Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
drivers/rtc/interface.c
drivers/rtc/rtc-cmos.c