net: gianfar: Add of_node_put() before goto statement
authorSumera Priyadarsini <sylphrenadin@gmail.com>
Tue, 18 Aug 2020 18:52:41 +0000 (00:22 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 3 Sep 2020 09:21:20 +0000 (11:21 +0200)
commit740cd42444f0bb7656b481f65a58ab691e25ac9c
tree9c85efd2827ddfc998f592169099d35da64bb336
parent0ad7639387e55320e59ccc8f0f2fae5518bb787b
net: gianfar: Add of_node_put() before goto statement

[ Upstream commit 989e4da042ca4a56bbaca9223d1a93639ad11e17 ]

Every iteration of for_each_available_child_of_node() decrements
reference count of the previous node, however when control
is transferred from the middle of the loop, as in the case of
a return or break or goto, there is no decrement thus ultimately
resulting in a memory leak.

Fix a potential memory leak in gianfar.c by inserting of_node_put()
before the goto statement.

Issue found with Coccinelle.

Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/freescale/gianfar.c