decompress_bunzip2: off by one in get_next_block()
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 13 Dec 2014 00:58:05 +0000 (16:58 -0800)
committerDanny Wood <danwood76@gmail.com>
Tue, 29 Jan 2019 13:06:05 +0000 (13:06 +0000)
commit73a301e6e9c8e550fca8ab0b319dfab9fc3a87e4
tree73b22b1ba25612dd55d52e410b449685a891e72b
parenta46e5e606ad89a58c74ac0ee1a50e440ca9a3830
decompress_bunzip2: off by one in get_next_block()

commit b5c8afe5be51078a979d86ae5ae78c4ac948063d upstream.

"origPtr" is used as an offset into the bd->dbuf[] array.  That array is
allocated in start_bunzip() and has "bd->dbufSize" number of elements so
the test here should be >= instead of >.

Later we check "origPtr" again before using it as an offset so I don't
know if this bug can be triggered in real life.

Fixes: bc22c17e12c1 ('bzip2/lzma: library support for gzip, bzip2 and lzma decompression')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Alain Knaff <alain@knaff.lu>
Cc: Yinghai Lu <yinghai@kernel.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
lib/decompress_bunzip2.c