x86/fpu: Simplify __save_fpu()
authorIngo Molnar <mingo@kernel.org>
Mon, 27 Apr 2015 07:23:43 +0000 (09:23 +0200)
committerIngo Molnar <mingo@kernel.org>
Tue, 19 May 2015 13:47:53 +0000 (15:47 +0200)
commit72ee6f87adcb7b7bdb71cc81c22858811ee1a069
treec506a3950852b59f2d99ec3b1793c5db2eb0d234
parent32b49b3c83cad1ba60494a00dad2f511a647fb5a
x86/fpu: Simplify __save_fpu()

__save_fpu() has this pattern:

if (unlikely(system_state == SYSTEM_BOOTING))
xsave_state_booting(&fpu->state.xsave);
else
xsave_state(&fpu->state.xsave);

... but it does not actually get called during system bootup.

So remove the complication and always call xsave_state().

To make sure this assumption is correct, add a WARN_ONCE()
debug check to xsave_state().

Reviewed-by: Borislav Petkov <bp@alien8.de>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/include/asm/fpu/xsave.h
arch/x86/kernel/fpu/core.c