netfilter: xt_TCPMSS: add more sanity tests on tcph->doff
authorEric Dumazet <edumazet@google.com>
Mon, 3 Apr 2017 17:55:11 +0000 (10:55 -0700)
committerWilly Tarreau <w@1wt.eu>
Thu, 2 Nov 2017 06:16:23 +0000 (07:16 +0100)
commit72d7b83afbc4659de5948c4cc33f5d7b47f09aa4
tree0c43082d391f5b0a713f3cf50731258acac39e07
parent946272f8a5f73b249808d1fb8f30a25724864466
netfilter: xt_TCPMSS: add more sanity tests on tcph->doff

commit 2638fd0f92d4397884fd991d8f4925cb3f081901 upstream.

Denys provided an awesome KASAN report pointing to an use
after free in xt_TCPMSS

I have provided three patches to fix this issue, either in xt_TCPMSS or
in xt_tcpudp.c. It seems xt_TCPMSS patch has the smallest possible
impact.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Denys Fedoryshchenko <nuclearcat@nuclearcat.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
[wt: adjust context]

Signed-off-by: Willy Tarreau <w@1wt.eu>
net/netfilter/xt_TCPMSS.c