staging: comedi: bug-fix NULL pointer dereference on failed attach
authorIan Abbott <abbotti@mev.co.uk>
Fri, 23 Aug 2013 11:37:17 +0000 (12:37 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Aug 2013 16:47:36 +0000 (09:47 -0700)
commit6f123e952c4144ddda16ebdac765677ebdf6f37c
tree603950849a1670973bdd6dd84a6778bc6b50a1a8
parent90dbc54a171ca7fd96c35d2858d30baf5d7c6376
staging: comedi: bug-fix NULL pointer dereference on failed attach

commit 3955dfa8216f712bc204a5ad2f4e51efff252fde upstream.

Commit dcd7b8bd63cb81c5b973bf86510ca3c80bbbd162 ("staging: comedi: put
module _after_ detach" by myself) reversed a couple of calls in
`comedi_device_attach()` when recovering from an error returned by the
low-level driver's 'attach' handler.  Unfortunately, that introduced a
NULL pointer dereference bug as `dev->driver` is NULL after the call to
`comedi_device_detach()`.   We still have a pointer to the low-level
comedi driver structure in the `driv` variable, so use that instead.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers.c