ext4: fix memory leak in xattr
authorDave Jones <davej@redhat.com>
Fri, 11 Oct 2013 00:05:35 +0000 (20:05 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Sat, 12 Oct 2013 18:39:49 +0000 (14:39 -0400)
commit6e4ea8e33b2057b85d75175dd89b93f5e26de3bc
treebc80cddd29e231c4068bfe40fe4f7693c48f65f3
parent9c12a831d73dd938a22418d70b39aed4feb4bdf2
ext4: fix memory leak in xattr

If we take the 2nd retry path in ext4_expand_extra_isize_ea, we
potentionally return from the function without having freed these
allocations.  If we don't do the return, we over-write the previous
allocation pointers, so we leak either way.

Spotted with Coverity.

[ Fixed by tytso to set is and bs to NULL after freeing these
  pointers, in case in the retry loop we later end up triggering an
  error causing a jump to cleanup, at which point we could have a double
  free bug. -- Ted ]

Signed-off-by: Dave Jones <davej@fedoraproject.org>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Cc: stable@vger.kernel.org
fs/ext4/xattr.c