tcp: reset sk_rx_dst in tcp_disconnect()
authorWANG Cong <xiyou.wangcong@gmail.com>
Sun, 25 Jun 2017 06:50:30 +0000 (23:50 -0700)
committerDanny Wood <danwood76@gmail.com>
Tue, 29 Jan 2019 13:18:23 +0000 (13:18 +0000)
commit6a4f002b7c9c447e11ea6e03e53d3c5efca6641d
treec53ecf23f39c5b32c6a7c7cf7fb19f0b0c7c613f
parent45a6ab60d3464ebeebc154e1ceea21297f3b9931
tcp: reset sk_rx_dst in tcp_disconnect()

commit d747a7a51b00984127a88113cdbbc26f91e9d815 upstream.

We have to reset the sk->sk_rx_dst when we disconnect a TCP
connection, because otherwise when we re-connect it this
dst reference is simply overridden in tcp_finish_connect().

This fixes a dst leak which leads to a loopback dev refcnt
leak. It is a long-standing bug, Kevin reported a very similar
(if not same) bug before. Thanks to Andrei for providing such
a reliable reproducer which greatly narrows down the problem.

Fixes: 41063e9dd119 ("ipv4: Early TCP socket demux.")
Reported-by: Andrei Vagin <avagin@gmail.com>
Reported-by: Kevin Xu <kaiwen.xu@hulu.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
[wt: adjusted context]

Signed-off-by: Willy Tarreau <w@1wt.eu>
net/ipv4/tcp.c