sched: Fix end_of_stack() and location of stack canary for architectures using CONFIG...
authorChuck Ebbert <cebbert.lkml@gmail.com>
Sat, 20 Sep 2014 15:17:51 +0000 (10:17 -0500)
committerIngo Molnar <mingo@kernel.org>
Sat, 20 Sep 2014 17:44:04 +0000 (19:44 +0200)
commit6a40281ab5c1ed8ba2253857118a5d400a2d084b
tree06fd733b2cb968c19adcc1f19566425e2d8e0167
parent46be7b73e82453447cd97b3440d523159eab09f8
sched: Fix end_of_stack() and location of stack canary for architectures using CONFIG_STACK_GROWSUP

Aaron Tomlin recently posted patches [1] to enable checking the
stack canary on every task switch. Looking at the canary code, I
realized that every arch (except ia64, which adds some space for
register spill above the stack) shares a definition of
end_of_stack() that makes it the first long after the
threadinfo.

For stacks that grow down, this low address is correct because
the stack starts at the end of the thread area and grows toward
lower addresses. However, for stacks that grow up, toward higher
addresses, this is wrong. (The stack actually grows away from
the canary.) On these archs end_of_stack() should return the
address of the last long, at the highest possible address for the stack.

[1] http://lkml.org/lkml/2014/9/12/293

Signed-off-by: Chuck Ebbert <cebbert.lkml@gmail.com>
Link: http://lkml.kernel.org/r/20140920101751.6c5166b6@as
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Tested-by: James Hogan <james.hogan@imgtec.com> [metag]
Acked-by: James Hogan <james.hogan@imgtec.com>
Acked-by: Aaron Tomlin <atomlin@redhat.com>
include/linux/sched.h