ext4: fix potential use after free in __ext4_journal_stop
authorLukas Czerner <lczerner@redhat.com>
Sun, 18 Oct 2015 02:57:06 +0000 (22:57 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Sun, 18 Oct 2015 02:57:06 +0000 (22:57 -0400)
commit6934da9238da947628be83635e365df41064b09b
treea7d5770b2fbd3961c40b6bb2da86873dcfab19c0
parent33d14975e5ac469963d5d63856b61698ad0bff07
ext4: fix potential use after free in __ext4_journal_stop

There is a use-after-free possibility in __ext4_journal_stop() in the
case that we free the handle in the first jbd2_journal_stop() because
we're referencing handle->h_err afterwards. This was introduced in
9705acd63b125dee8b15c705216d7186daea4625 and it is wrong. Fix it by
storing the handle->h_err value beforehand and avoid referencing
potentially freed handle.

Fixes: 9705acd63b125dee8b15c705216d7186daea4625
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Cc: stable@vger.kernel.org
fs/ext4/ext4_jbd2.c