ASoC: dapm: Fix uninitialized variable in snd_soc_dapm_get_enum_double()
authorGeert Uytterhoeven <geert+renesas@glider.be>
Fri, 8 Aug 2014 15:29:35 +0000 (17:29 +0200)
committerMark Brown <broonie@linaro.org>
Mon, 11 Aug 2014 19:01:13 +0000 (20:01 +0100)
commit6912831623c5bbd38c6c26039d5f821557e5f541
treee3b85d99c34d370673252b22a4800afb0d0bdb07
parentae34a78c430c37c06404f032fb04e51315204281
ASoC: dapm: Fix uninitialized variable in snd_soc_dapm_get_enum_double()

If soc_dapm_read() fails, reg_val will be uninitialized, and bogus
values will be written later:

sound/soc/soc-dapm.c: In function 'snd_soc_dapm_get_enum_double':
sound/soc/soc-dapm.c:2862:15: warning: 'reg_val' may be used uninitialized in this function [-Wmaybe-uninitialized]
  unsigned int reg_val, val;
               ^

Return early on error to fix this.

Introduced by commit ce0fc93ae56e2ba50ff8c220d69e4e860e889320 ("ASoC:
Add DAPM support at the component level").

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Mark Brown <broonie@linaro.org>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
sound/soc/soc-dapm.c