unfuck sysfs_mount()
authorAl Viro <viro@zeniv.linux.org.uk>
Mon, 14 May 2018 04:03:34 +0000 (00:03 -0400)
committerSasha Levin <sashal@kernel.org>
Wed, 30 Jun 2021 12:48:55 +0000 (08:48 -0400)
commit68fed0725820073d37e487bfa7eeb73eb0e63478
tree8b7e2c5fd276e42dd61591eb86b2597509f7acbe
parente83ca3bdb895e581a6c541515e9fd2cfb9e60ed4
unfuck sysfs_mount()

commit 7b745a4e4051e1bbce40e0b1c2cf636c70583aa4 upstream.

new_sb is left uninitialized in case of early failures in kernfs_mount_ns(),
and while IS_ERR(root) is true in all such cases, using IS_ERR(root) || !new_sb
is not a solution - IS_ERR(root) is true in some cases when new_sb is true.

Make sure new_sb is initialized (and matches the reality) in all cases and
fix the condition for dropping kobj reference - we want it done precisely
in those situations where the reference has not been transferred into a new
super_block instance.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/sysfs/mount.c