binder: fix memory leak in error path
authorTodd Kjos <tkjos@android.com>
Fri, 21 Jun 2019 17:54:15 +0000 (10:54 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 21 Jul 2019 07:04:36 +0000 (09:04 +0200)
commit67f6f4a6d4219ae78198880a17ab74d057449d0f
tree6b93681b9cbdcd8e13117fd7a0bae61b55cf63ef
parentcea29db65e075585dbc8b58e9119c1447ad1adc4
binder: fix memory leak in error path

commit 1909a671dbc3606685b1daf8b22a16f65ea7edda upstream.

syzkallar found a 32-byte memory leak in a rarely executed error
case. The transaction complete work item was not freed if put_user()
failed when writing the BR_TRANSACTION_COMPLETE to the user command
buffer. Fixed by freeing it before put_user() is called.

Reported-by: syzbot+182ce46596c3f2e1eb24@syzkaller.appspotmail.com
Signed-off-by: Todd Kjos <tkjos@google.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/android/binder.c