perf probe: Do not use dwfl_module_addrsym if dwarf_diename finds symbol name
authorMasami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Wed, 17 Sep 2014 08:41:01 +0000 (08:41 +0000)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 17 Sep 2014 21:01:43 +0000 (18:01 -0300)
commit664fee3dc37939bb8010906913fa9dbc52abb587
tree72972d1684a1a4930039cfae22d0799aad8738f7
parent2b394bc4468c2f5e6814a8dbb2a923c0448f8497
perf probe: Do not use dwfl_module_addrsym if dwarf_diename finds symbol name

Do not use dwfl_module_addrsym if dwarf_diename can find the symbol
name, since dwfl_module_addrsym can be failed on shared libraries.

Without this patch
  ----
  $ perf probe -x ../lib/traceevent/libtraceevent.so -V create_arg_op
  Failed to find symbol at 0x11df1
  Failed to find the address of create_arg_op
    Error: Failed to show vars.
  ----
With this patch
  ----
  $ perf probe -x ../lib/traceevent/libtraceevent.so -V create_arg_op
  Available variables at create_arg_op
          @<create_arg_op+0>
                  enum filter_op_type     btype
                  struct filter_arg*      arg
  ----

This bug was reported on linux-perf-users@vger.kernel.org.

Reported-by: david lerner <dlernerdroid@gmail.com>
Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: david lerner <dlernerdroid@gmail.com>
Cc: linux-perf-user@vger.kernel.org
Cc: yrl.pp-manager.tt@hitachi.com
Link: http://permalink.gmane.org/gmane.linux.kernel.perf.user/1691
Link: http://lkml.kernel.org/r/20140917084101.3722.25299.stgit@kbuild-f20.novalocal
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/probe-finder.c