spi/topcliff: cleanups for style and conciseness
authorGrant Likely <grant.likely@secretlab.ca>
Wed, 29 Sep 2010 08:31:34 +0000 (17:31 +0900)
committerGrant Likely <grant.likely@secretlab.ca>
Wed, 13 Oct 2010 03:37:37 +0000 (21:37 -0600)
commit65308c46b760bb2ccb043b47bb5f053dbb8d11b5
treeb1207bb74c3c8e04ac0dbe856b0b449011d7d19a
parente8b17b5b3f30252b5470dbbf54bc251ddc7fac17
spi/topcliff: cleanups for style and conciseness

This patch makes multiple cleanups to the new topcliff pch spi driver
including, but not limited to,
- removing superfluous brackets around variables
- open coding functions that are only used once
- removing unnecessary line breaks
- removing unused functions
- simplifying the interrupt enable/disable code
- remove unnecessary (void *) casts.
- remove b_mem_fail from pch_spi_set_tx to code it more cleanly
- shorten dev_dbg() messages for conciseness and readability

More cleanups are still needed in this driver.  In particular,
- the driver filename should be changed to spi_topcliff_pch.c
- many of the dev_dbg() lines should be trimmed (particularly the ones
  on unconditional code paths).
- I suspect that the locking model not correct.  I'd like to know what
  drivers' critical regions are, and how they are protected.
- get_resources and release_resources probably should be open coded in
  .probe and .release respectively.

Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
drivers/spi/spi_topcliff_pch.c