projects / GitHub / moto-9609 / android_kernel_motorola_exynos9610.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 5a9ff85) | patch
[media] pms: Fix a bad usage of the stack
authorMauro Carvalho Chehab <mchehab@osg.samsung.com>
Wed, 24 Sep 2014 18:35:55 +0000 (15:35 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Fri, 26 Sep 2014 09:47:55 +0000 (06:47 -0300)
commit64e01cbd9d3e22e38eadeff9e0d251d0d7d1c9d2
treeeef9c68d65d7e6e08c65512dbb0a7314dcf77e10tree | snapshot (tar.gz zip)
parent5a9ff85dc176e80c6fb7067dcb807c5e3ff7a913commit | diff
[media] pms: Fix a bad usage of the stack

As warned by smatch:
drivers/media/parport/pms.c:632:21: warning: Variable length array is used.

The pms driver is doing something really bad: it is using the
stack to read data into a buffer whose size is given by the
user by the read() syscall. Replace it by a dynamically allocated
buffer.

Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/parport/pms.c diff | blob | blame | history