printk: use console_trylock() in console_cpu_notify()
authorSergey Senozhatsky <sergey.senozhatsky@gmail.com>
Sat, 21 Jan 2017 10:47:29 +0000 (19:47 +0900)
committerPetr Mladek <pmladek@suse.com>
Fri, 24 Mar 2017 15:09:46 +0000 (16:09 +0100)
commit64ca752dcbc018054bfea53b784d4c85d3ec896c
tree8b11043b4bc3b6cf60a7297a951929a887236527
parent7d91de74436a69c2b78a7a72f1e7f97f8b4396fa
printk: use console_trylock() in console_cpu_notify()

There is no need to always call blocking console_lock() in
console_cpu_notify(), it's quite possible that console_sem can
be locked by other CPU on the system, either already printing
or soon to begin printing the messages. console_lock() in this
case can simply block CPU hotplug for unknown period of time
(console_unlock() is time unbound). Not that hotplug is very
fast, but still, with other CPUs being online and doing
printk() console_cpu_notify() can stuck.

Use console_trylock() instead and opt-out if console_sem is
already acquired from another CPU, since that CPU will do
the printing for us.

Link: http://lkml.kernel.org/r/20170121104729.8585-1-sergey.senozhatsky@gmail.com
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
kernel/printk/printk.c