metag: Only define atomic_dec_if_positive conditionally
authorGuenter Roeck <linux@roeck-us.net>
Fri, 7 Oct 2016 17:40:59 +0000 (10:40 -0700)
committerWilly Tarreau <w@1wt.eu>
Fri, 10 Feb 2017 10:04:09 +0000 (11:04 +0100)
commit63d7f335d653b9a63ecf1f75f73c82f41870a7af
tree04e7cdf69155002ee8b89c348579903093c7dc82
parent16654a56f02b36e9377d991853227f598d3bdbf6
metag: Only define atomic_dec_if_positive conditionally

commit 35d04077ad96ed33ceea2501f5a4f1eacda77218 upstream.

The definition of atomic_dec_if_positive() assumes that
atomic_sub_if_positive() exists, which is only the case if
metag specific atomics are used. This results in the following
build error when trying to build metag1_defconfig.

kernel/ucount.c: In function 'dec_ucount':
kernel/ucount.c:211: error:
implicit declaration of function 'atomic_sub_if_positive'

Moving the definition of atomic_dec_if_positive() into the metag
conditional code fixes the problem.

Fixes: 6006c0d8ce94 ("metag: Atomics, locks and bitops")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
arch/metag/include/asm/atomic.h