sched/fair: Fix the dealing with decay_count in __synchronize_entity_decay()
authorXunlei Pang <pang.xunlei@linaro.org>
Tue, 16 Dec 2014 15:58:29 +0000 (23:58 +0800)
committerIngo Molnar <mingo@kernel.org>
Wed, 14 Jan 2015 12:34:13 +0000 (13:34 +0100)
commit638476007d13534b2ed4134bf0279ef44071140b
treeaa8ee17a7fba6a4c80c66057b2e257568db8080e
parent7f1a169b88f513e32a432ca0f85bfd282d117bd6
sched/fair: Fix the dealing with decay_count in __synchronize_entity_decay()

In __synchronize_entity_decay(), if "decays" happens to be zero,
se->avg.decay_count will not be zeroed, holding the positive value
assigned when dequeued last time.

This is problematic in the following case:
If this runnable task is CFS-balanced to other CPUs soon afterwards,
migrate_task_rq_fair() will treat it as a blocked task due to its
non-zero decay_count, thereby adding its load to cfs_rq->removed_load
wrongly.

Thus, we must zero se->avg.decay_count in this case as well.

Signed-off-by: Xunlei Pang <pang.xunlei@linaro.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Ben Segall <bsegall@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/1418745509-2609-1-git-send-email-pang.xunlei@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/fair.c