networking: add and use skb_put_u8()
authorJohannes Berg <johannes.berg@intel.com>
Fri, 16 Jun 2017 12:29:24 +0000 (14:29 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 16 Jun 2017 15:48:40 +0000 (11:48 -0400)
commit634fef61076d644b989b86abc2f560d81a089a31
tree41e0cfc0c640666a75ad07588df34addb18176d0
parentd58ff35122847a83ba55394e2ae3a1527b6febf5
networking: add and use skb_put_u8()

Joe and Bjørn suggested that it'd be nicer to not have the
cast in the fairly common case of doing
*(u8 *)skb_put(skb, 1) = c;

Add skb_put_u8() for this case, and use it across the code,
using the following spatch:

    @@
    expression SKB, C, S;
    typedef u8;
    identifier fn = {skb_put};
    fresh identifier fn2 = fn ## "_u8";
    @@
    - *(u8 *)fn(SKB, S) = C;
    + fn2(SKB, C);

Note that due to the "S", the spatch isn't perfect, it should
have checked that S is 1, but there's also places that use a
sizeof expression like sizeof(var) or sizeof(u8) etc. Turns
out that nobody ever did something like
*(u8 *)skb_put(skb, 2) = c;

which would be wrong anyway since the second byte wouldn't be
initialized.

Suggested-by: Joe Perches <joe@perches.com>
Suggested-by: Bjørn Mork <bjorn@mork.no>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
39 files changed:
drivers/bluetooth/bluecard_cs.c
drivers/bluetooth/bt3c_cs.c
drivers/bluetooth/btuart_cs.c
drivers/bluetooth/btusb.c
drivers/bluetooth/dtl1_cs.c
drivers/bluetooth/hci_bcm.c
drivers/bluetooth/hci_intel.c
drivers/bluetooth/hci_nokia.c
drivers/bluetooth/hci_qca.c
drivers/bluetooth/hci_vhci.c
drivers/isdn/capi/capi.c
drivers/isdn/gigaset/asyncdata.c
drivers/isdn/i4l/isdn_bsdcomp.c
drivers/isdn/i4l/isdn_x25iface.c
drivers/net/hamradio/scc.c
drivers/net/usb/cdc_ncm.c
drivers/net/usb/net1080.c
drivers/net/usb/zaurus.c
drivers/nfc/fdp/i2c.c
drivers/nfc/microread/i2c.c
drivers/nfc/microread/microread.c
drivers/nfc/nfcmrvl/fw_dnld.c
drivers/nfc/pn533/pn533.c
drivers/nfc/pn544/i2c.c
drivers/nfc/port100.c
drivers/nfc/st21nfca/i2c.c
drivers/nfc/st95hf/core.c
include/linux/skbuff.h
net/bluetooth/hci_sock.c
net/bluetooth/hidp/core.c
net/decnet/dn_nsp_out.c
net/nfc/digital_core.c
net/nfc/digital_dep.c
net/nfc/digital_technology.c
net/nfc/hci/core.c
net/nfc/hci/llc_shdlc.c
net/nfc/nci/hci.c
net/nfc/nci/spi.c
net/nfc/nci/uart.c