ptp: use permission-specific DEVICE_ATTR variants
authorJulia Lawall <julia.lawall@lip6.fr>
Sat, 29 Oct 2016 19:37:06 +0000 (21:37 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 31 Oct 2016 19:32:12 +0000 (15:32 -0400)
commit63215705a6cc4481dde21b5343bb706837f273d9
tree093cad568732fbd9d5b3baa54a47d04ce86de936
parent0f98621bef5d2b7ad41f6595899660af344f5016
ptp: use permission-specific DEVICE_ATTR variants

Use DEVICE_ATTR_RO for read only attributes.  This simplifies the
source code, improves readbility, and reduces the chance of
inconsistencies.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@ro@
declarer name DEVICE_ATTR;
identifier x,x_show;
@@

DEVICE_ATTR(x, \(0444\|S_IRUGO\), x_show, NULL);

@script:ocaml@
x << ro.x;
x_show << ro.x_show;
@@

if not (x^"_show" = x_show) then Coccilib.include_match false

@@
declarer name DEVICE_ATTR_RO;
identifier ro.x,ro.x_show;
@@

- DEVICE_ATTR(x, \(0444\|S_IRUGO\), x_show, NULL);
+ DEVICE_ATTR_RO(x);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/ptp/ptp_sysfs.c