tracing, sched, vfs: Fix 'old_pid' usage in trace_sched_process_exec()
authorOleg Nesterov <oleg@redhat.com>
Fri, 30 Mar 2012 16:26:36 +0000 (18:26 +0200)
committerIngo Molnar <mingo@kernel.org>
Sat, 31 Mar 2012 09:53:22 +0000 (11:53 +0200)
commit6308191f6f55d3629c7dbe72dfb856ad9fa560fd
treed3f073b0e522fc7dbee52ca6c25d92f28059f2fd
parent8ebfdf2babcda5a3b06cc67523bca1f9aed46009
tracing, sched, vfs: Fix 'old_pid' usage in trace_sched_process_exec()

1. TRACE_EVENT(sched_process_exec) forgets to actually use the
   old pid argument, it sets ->old_pid = p->pid.

2. search_binary_handler() uses the wrong pid number. tracepoint
   needs the global pid_t from the root namespace, while old_pid
   is the virtual pid number as it seen by the tracer/parent.

With this patch we have two pid_t's in search_binary_handler(),
not really nice. Perhaps we should switch to "struct pid*", but
in this case it would be better to cleanup the current code
first and move the "depth == 0" code outside.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: David Smith <dsmith@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Link: http://lkml.kernel.org/r/20120330162636.GA4857@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
fs/exec.c
include/trace/events/sched.h