parisc: Ensure consistent state when switching to kernel stack at syscall entry
authorJohn David Anglin <dave.anglin@bell.net>
Sat, 29 Oct 2016 03:00:34 +0000 (23:00 -0400)
committerWilly Tarreau <w@1wt.eu>
Mon, 6 Feb 2017 22:32:57 +0000 (23:32 +0100)
commit61f2d84aa4c053f7dde303c8066d7fdbbc8374e2
treec26ca38289d4b3237c07dfadc39c79129fda9dbc
parent2fe6f38f919939486edb08a4dcc83e41144af2ed
parisc: Ensure consistent state when switching to kernel stack at syscall entry

commit 6ed518328d0189e0fdf1bb7c73290d546143ea66 upstream.

We have one critical section in the syscall entry path in which we switch from
the userspace stack to kernel stack. In the event of an external interrupt, the
interrupt code distinguishes between those two states by analyzing the value of
sr7. If sr7 is zero, it uses the kernel stack. Therefore it's important, that
the value of sr7 is in sync with the currently enabled stack.

This patch now disables interrupts while executing the critical section.  This
prevents the interrupt handler to possibly see an inconsistent state which in
the worst case can lead to crashes.

Interestingly, in the syscall exit path interrupts were already disabled in the
critical section which switches back to the userspace stack.

Signed-off-by: John David Anglin <dave.anglin@bell.net>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Willy Tarreau <w@1wt.eu>
arch/parisc/kernel/syscall.S