netfilter: conntrack: fix CT target for UNSPEC helpers
authorFlorian Westphal <fw@strlen.de>
Thu, 3 Nov 2016 13:44:42 +0000 (14:44 +0100)
committerPablo Neira Ayuso <pablo@netfilter.org>
Tue, 8 Nov 2016 22:53:37 +0000 (23:53 +0100)
commit6114cc516dcc0d311badb83ad7db5aa4b611bea6
treee1d791b97983fd274ea3c47219f953562efec2d3
parentfb9c9649a1d0a65a8f94f784aa18252a0dd584c1
netfilter: conntrack: fix CT target for UNSPEC helpers

Thomas reports its not possible to attach the H.245 helper:

iptables -t raw -A PREROUTING -p udp -j CT --helper H.245
iptables: No chain/target/match by that name.
xt_CT: No such helper "H.245"

This is because H.245 registers as NFPROTO_UNSPEC, but the CT target
passes NFPROTO_IPV4/IPV6 to nf_conntrack_helper_try_module_get.

We should treat UNSPEC as wildcard and ignore the l3num instead.

Reported-by: Thomas Woerner <twoerner@redhat.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_conntrack_helper.c