target/iscsi: Fix double free in lio_target_tiqn_addtpg()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 13 Dec 2016 12:27:04 +0000 (15:27 +0300)
committerWilly Tarreau <w@1wt.eu>
Wed, 7 Jun 2017 22:46:53 +0000 (00:46 +0200)
commit6075e944fe561a1b2460129ef09d2f644bde75eb
tree0564474647a04d610c3591879a7cd2edcba31740
parent4d091cfb5a1c0e142b3c719cc8393012180f15e1
target/iscsi: Fix double free in lio_target_tiqn_addtpg()

commit a91918cd3ea11f91c68e08e1e8ce1b560447a80e upstream.

This iscsit_tpg_add_portal_group() function is only called from
lio_target_tiqn_addtpg().  Both functions free the "tpg" pointer on
error so it's a double free bug.  The memory is allocated in the caller
so it should be freed in the caller and not here.

Fixes: e48354ce078c ("iscsi-target: Add iSCSI fabric support for target v4.1")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: David Disseldorp <ddiss@suse.de>
[ bvanassche: Added "Fix" at start of patch title ]
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/target/iscsi/iscsi_target_tpg.c