md/raid1: extend spinlock to protect raid1_end_read_request against inconsistencies
authorNeilBrown <neilb@suse.com>
Mon, 27 Jul 2015 01:48:52 +0000 (11:48 +1000)
committerDanny Wood <danwood76@gmail.com>
Tue, 29 Jan 2019 13:09:46 +0000 (13:09 +0000)
commit5ee900a9e5eb45e81f89689b93a636cdc4222411
treec8a8b723d5bdb7683f27f0587853de5723ac4234
parenta39b992834774fb13b4665c754a5b77a38703d10
md/raid1: extend spinlock to protect raid1_end_read_request against inconsistencies

commit 423f04d63cf421ea436bcc5be02543d549ce4b28 upstream.

raid1_end_read_request() assumes that the In_sync bits are consistent
with the ->degaded count.
raid1_spare_active updates the In_sync bit before the ->degraded count
and so exposes an inconsistency, as does error()
So extend the spinlock in raid1_spare_active() and error() to hide those
inconsistencies.

This should probably be part of
  Commit: 34cab6f42003 ("md/raid1: fix test for 'was read error from
  last working device'.")
as it addresses the same issue.  It fixes the same bug and should go
to -stable for same reasons.

Fixes: 76073054c95b ("md/raid1: clean up read_balance.")
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/md/raid1.c