drbd: remove useless kobject_uevent from drbd_adm_connect
authorLars Ellenberg <lars.ellenberg@linbit.com>
Tue, 26 Apr 2011 14:22:25 +0000 (16:22 +0200)
committerPhilipp Reisner <philipp.reisner@linbit.com>
Thu, 8 Nov 2012 15:49:07 +0000 (16:49 +0100)
commit5ee743e92d3b170a67b58c0c6ea169300983f58e
tree8f5b7b0de71cbb44281343e85b78cd046bd2513c
parenta18e9d1eb0660621eb9911e59a9b4d664cbad4d9
drbd: remove useless kobject_uevent from drbd_adm_connect

Calling kobject_uevent, which may sleep, from within rcu_read_lock()
protected regions is not possible.
This particular kobject_uevent also is also wrong. It was supposed to
trigger a udev run, just in case something relevant to udev symlink
magic has changed, when adjusting runtime re-configurable settings while
we still had the "syncer conf".  It was improperly placed in connect
when we dropped the "syncer conf".  The right thing to do is probably to
call "udevadm trigger" directly in those cases where drbdadm thinks
there was a need to trigger extra udev runs.

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
drivers/block/drbd/drbd_nl.c