usb: phy: twl6030-usb: fix possible use-after-free on remove
authorSven Van Asbroeck <thesven73@gmail.com>
Mon, 11 Feb 2019 15:04:26 +0000 (10:04 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Jan 2020 09:24:15 +0000 (10:24 +0100)
commit5ebf6e3e407b20f17fb000b275042e43612ee76a
tree2011ca43e4a6ab8ab0fea733935faffc93564898
parent8fc5c594d32d5b22d30c952bd1580ecb02d9ab09
usb: phy: twl6030-usb: fix possible use-after-free on remove

[ Upstream commit 5895d311d28f2605e2f71c1a3e043ed38f3ac9d2 ]

In remove(), use cancel_delayed_work_sync() to cancel the
delayed work. Otherwise there's a chance that this work
will continue to run until after the device has been removed.

This issue was detected with the help of Coccinelle.

Cc: Tony Lindgren <tony@atomide.com>
Cc: Bin Liu <b-liu@ti.com>
Fixes: b6a619a883c3 ("usb: phy: Check initial state for twl6030")
Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/phy/phy-twl6030-usb.c