bcm63xx_enet: do not overwrite ENET_CTL_REG value
authorFlorian Fainelli <ffainelli@freebox.fr>
Fri, 9 Apr 2010 01:04:52 +0000 (01:04 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 13 Apr 2010 10:29:36 +0000 (03:29 -0700)
commit5e10d4a7fc80e4ef310c07a6a547406fef50534a
tree7403140f22fbdbb454d990f1d1a4b504aa235bc0
parent0de8655ab9181cbaca82aa60402b14118e06d030
bcm63xx_enet: do not overwrite ENET_CTL_REG value

bcm_enet_hw_preinit will correctly set values in ENET_CTL_REG for internal
or external MII operations, however, bcm_enet_open will blindly overwrite the
ENET_CTL_REG register value and thus we will loose any changes to it that
were made in bcm_enet_hw_preinit, rendering external MII operations non-working.

This would lead to the driver not being able to check for link availability on
external PHY setups, and thus we would never get to sending packets because
link was down from the driver side.

This was completely un-noticed because all boards out there but BCM6338-based
ones use internal phy on their enet0 interface.

Signed-off-by: Florian Fainelli <ffainelli@freebox.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bcm63xx_enet.c