[SCSI] don't reference freed command in scsi_init_sgtable
authorChristoph Hellwig <hch@lst.de>
Tue, 15 Apr 2014 10:24:55 +0000 (12:24 +0200)
committerJames Bottomley <JBottomley@Parallels.com>
Mon, 21 Apr 2014 14:57:21 +0000 (07:57 -0700)
commit5e012aad85f2ee31d7de5c21d63ccd2702d63db2
treefa90a6a3e94a5c3112b3bbdf114c637aa7166eba
parent67c99a72e3006e4276e91d7282a3d6734fc77a0b
[SCSI] don't reference freed command in scsi_init_sgtable

Patch

commit 0479633686d370303e3430256ace4bd5f7f138dc
Author: Christoph Hellwig <hch@infradead.org>
Date:   Thu Feb 20 14:20:55 2014 -0800

    [SCSI] do not manipulate device reference counts in scsi_get/put_command

Introduced a use after free: when scsi_init_io fails we have to release our
device reference, but we do this trying to reference the just freed command.
Add a local scsi_device pointer to fix this.

Fixes: 0479633686d370303e3430256ace4bd5f7f138dc
Reported-by: Sander Eikelenboom <linux@eikelenboom.it>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/scsi/scsi_lib.c