[media] cx88: Fix unsafe locking in suspend-resume
authorAlexey Khoroshilov <khoroshilov@ispras.ru>
Sat, 13 Apr 2013 21:52:04 +0000 (18:52 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Mon, 22 Apr 2013 13:08:30 +0000 (10:08 -0300)
commit5ddfbbb9ca2e74d4b392ccef675641babba6b7f8
tree8e2be3b14c057112be5d5d9fb8a708df2f06cc1e
parentcdcfe40a5fee6a3300632b9a6e7f9de596f0b450
[media] cx88: Fix unsafe locking in suspend-resume

Legacy PCI suspend-resume handlers are called with interrupts enabled.

But cx8800_suspend/cx8800_resume and
cx8802_suspend_common/cx8802_resume_common use spin_lock/spin_unlock
functions to acquire dev->slock, while the same lock is acquired in the
corresponding irq-handlers: cx8800_irq and cx8802_irq.

That means a deadlock is possible if an interrupt happens while suspend
or resume owns the lock. The patch replaces spin_lock/spin_unlock with
spin_lock_irqsave/spin_unlock_irqrestore.

Found by Linux Driver Verification project (linuxtesting.org).

[mchehab@redhat.com: Fix CodingStyle]
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/pci/cx88/cx88-mpeg.c
drivers/media/pci/cx88/cx88-video.c