dlm: don't do pointless NULL check, use kzalloc and fix order of arguments
authorJesper Juhl <jj@chaosbits.net>
Sun, 10 Jul 2011 20:54:31 +0000 (22:54 +0200)
committerDavid Teigland <teigland@redhat.com>
Mon, 11 Jul 2011 13:39:42 +0000 (08:39 -0500)
commit5d70828a7703b1f68e2fd4ce4b42b28d9623f52b
tree8ec65e9895776d568a475e3e8796fe9ababe8d2e
parentbcaadf5c1ac4ff84b52174a84adb86a1e3e806dd
dlm: don't do pointless NULL check, use kzalloc and fix order of arguments

In fs/dlm/lock.c in the dlm_scan_waiters() function there are 3 small
issues:

1) There's no need to test the return value of the allocation and do a
memset if is succeedes. Just use kzalloc() to obtain zeroed memory.

2) Since kfree() handles NULL pointers gracefully, the test of
'warned' against NULL before the kfree() after the loop is completely
pointless. Remove it.

3) The arguments to kmalloc() (now kzalloc()) were swapped. Thanks to
Dr. David Alan Gilbert for pointing this out.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: David Teigland <teigland@redhat.com>
fs/dlm/lock.c