sched: Migrate waking tasks
authorLai Jiangshan <laijs@cn.fujitsu.com>
Wed, 4 Jun 2014 08:25:15 +0000 (16:25 +0800)
committerIngo Molnar <mingo@kernel.org>
Tue, 9 Sep 2014 04:47:27 +0000 (06:47 +0200)
commit5cd038f53ed9ec7a17ab7d536a727363080f4210
tree69516cf3b08e4bf060bd45dd0545646dea724c17
parenteb1b4af0a64ac7bb0ee36f579c1c7cefcbc3ac2c
sched: Migrate waking tasks

Current code can fail to migrate a waking task (silently) when TTWU_QUEUE is
enabled.

When a task is waking, it is pending on the wake_list of the rq, but it is not
queued (task->on_rq == 0). In this case, set_cpus_allowed_ptr() and
__migrate_task() will not migrate it because its invisible to them.

This behavior is incorrect, because the task has been already woken, it will be
running on the wrong CPU without correct placement until the next wake-up or
update for cpus_allowed.

To fix this problem, we need to finish the wakeup (so they appear on
the runqueue) before we migrate them.

Reported-by: Sasha Levin <sasha.levin@oracle.com>
Reported-by: Jason J. Herne <jjherne@linux.vnet.ibm.com>
Tested-by: Jason J. Herne <jjherne@linux.vnet.ibm.com>
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/538ED7EB.5050303@cn.fujitsu.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/core.c