Input: joydev - fix possible ERR_PTR() dereferencing
authorJavier Martinez Canillas <javier@osg.samsung.com>
Tue, 6 Oct 2015 22:23:36 +0000 (15:23 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 6 Oct 2015 23:38:40 +0000 (16:38 -0700)
commit5b21e3c740b770fb2548a5a8ea66e544d114d0a8
tree083a82b82f4fcb4b4c24e6651126ed31036cd9df
parentc7efd123500b11568ce928a5cd91ad132ec36df5
Input: joydev - fix possible ERR_PTR() dereferencing

Commit 5702222c9a7a ("Input: joydev - use memdup_user() to duplicate
memory from user-space") changed the kmalloc() and copy_from_user()
with a single call to memdup_user() but wrongly used the same error
path than the old code in which the buffer allocated by kmalloc() was
freed if copy_from_user() failed.

This is of course wrong since if memdup_user() fails, no memory was
allocated and the error in the error-valued pointer should be returned.

Fixes: 5702222c9a7a ("Input: joydev - use memdup_user() to duplicate
memory from user-space")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/joydev.c