RCU: Don't try and predeclare inline funcs as it upsets some versions of gcc
authorDavid Howells <dhowells@redhat.com>
Wed, 15 Apr 2009 18:35:01 +0000 (19:35 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 15 Apr 2009 20:55:14 +0000 (13:55 -0700)
commit5b1d07ed0e5b2707f786957c7a40eb2f399c84a8
tree3cfb5d2004dd9858ef9d4d08f6cdc42b886354fb
parentda60682c116855cf342926b4f3427079400ee7e6
RCU: Don't try and predeclare inline funcs as it upsets some versions of gcc

Don't try and predeclare inline funcs like this:

static inline void wait_migrated_callbacks(void)
...
static void _rcu_barrier(enum rcu_barrier type)
{
...
wait_migrated_callbacks();
}
...
static inline void wait_migrated_callbacks(void)
{
wait_event(rcu_migrate_wq, !atomic_read(&rcu_migrate_type_count));
}

as it upsets some versions of gcc under some circumstances:

kernel/rcupdate.c: In function `_rcu_barrier':
kernel/rcupdate.c:125: sorry, unimplemented: inlining failed in call to 'wait_migrated_callbacks': function body not available
kernel/rcupdate.c:152: sorry, unimplemented: called from here

This can be dealt with by simply putting the static variables (rcu_migrate_*)
at the top, and moving the implementation of the function up so that it
replaces its forward declaration.

Signed-off-by: David Howells <dhowells@redhat.com>
Cc: Dipankar Sarma <dipankar@in.ibm.com>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/rcupdate.c