infiniband: hns: avoid gcc-7.0.1 warning for uninitialized data
authorArnd Bergmann <arnd@arndb.de>
Fri, 24 Mar 2017 22:02:48 +0000 (23:02 +0100)
committerDoug Ledford <dledford@redhat.com>
Tue, 25 Apr 2017 19:16:38 +0000 (15:16 -0400)
commit5b0ff9a00755d4d9c209033a77f1ed8f3186fe5c
tree440849dda0a2459858d98d7859a859a885a61de1
parent50b6778c44e426d7ef7ae30e06314f511faf383a
infiniband: hns: avoid gcc-7.0.1 warning for uninitialized data

hns_roce_v1_cq_set_ci() calls roce_set_bit() on an uninitialized field,
which will then change only a few of its bits, causing a warning with
the latest gcc:

infiniband/hw/hns/hns_roce_hw_v1.c: In function 'hns_roce_v1_cq_set_ci':
infiniband/hw/hns/hns_roce_hw_v1.c:1854:23: error: 'doorbell[1]' is used uninitialized in this function [-Werror=uninitialized]
  roce_set_bit(doorbell[1], ROCEE_DB_OTHERS_H_ROCEE_DB_OTH_HW_SYNS_S, 1);

The code is actually correct since we always set all bits of the
port_vlan field, but gcc correctly points out that the first
access does contain uninitialized data.

This initializes the field to zero first before setting the
individual bits.

Fixes: 9a4435375cd1 ("IB/hns: Add driver files for hns RoCE driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/hw/hns/hns_roce_hw_v1.c