oom: do not kill tasks with oom_score_adj OOM_SCORE_ADJ_MIN
authorMichal Hocko <mhocko@suse.cz>
Tue, 15 Nov 2011 22:36:07 +0000 (14:36 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 16 Nov 2011 00:41:51 +0000 (22:41 -0200)
commit5aecc85abdb9ac2b0e6548d13652a34142e7ae89
tree8939325e1ab98bce8caf16d9bdd3e57cd73af846
parent001ef5e4554b851cf50fe03bc4c266c28ed8e62d
oom: do not kill tasks with oom_score_adj OOM_SCORE_ADJ_MIN

Commit c9f01245 ("oom: remove oom_disable_count") has removed the
oom_disable_count counter which has been used for early break out from
oom_badness so we could never select a task with oom_score_adj set to
OOM_SCORE_ADJ_MIN (oom disabled).

Now that the counter is gone we are always going through heuristics
calculation and we always return a non zero positive value.  This means
that we can end up killing a task with OOM disabled because it is
indistinguishable from regular tasks with 1% resp.  CAP_SYS_ADMIN tasks
with 3% usage of memory or tasks with oom_score_adj set but OOM enabled.

Let's break out early if the task should have OOM disabled.

Signed-off-by: Michal Hocko <mhocko@suse.cz>
Acked-by: David Rientjes <rientjes@google.com>
Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Ying Han <yinghan@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/oom_kill.c