ACPI / power: Avoid maybe-uninitialized warning
authorArnd Bergmann <arnd@arndb.de>
Wed, 19 Apr 2017 17:47:04 +0000 (19:47 +0200)
committerDanny Wood <danwood76@gmail.com>
Tue, 29 Jan 2019 13:17:44 +0000 (13:17 +0000)
commit592615b7c9ba7c4eb455bae0c1a76ae5ace14104
tree93ace02813f41995706d97be2ed0d3b23c20bae2
parent0b524e33f082107d154fa37f201f524e3ec76462
ACPI / power: Avoid maybe-uninitialized warning

commit fe8c470ab87d90e4b5115902dd94eced7e3305c3 upstream.

gcc -O2 cannot always prove that the loop in acpi_power_get_inferred_state()
is enterered at least once, so it assumes that cur_state might not get
initialized:

drivers/acpi/power.c: In function 'acpi_power_get_inferred_state':
drivers/acpi/power.c:222:9: error: 'cur_state' may be used uninitialized in this function [-Werror=maybe-uninitialized]

This sets the variable to zero at the start of the loop, to ensure that
there is well-defined behavior even for an empty list. This gets rid of
the warning.

The warning first showed up when the -Os flag got removed in a bug fix
patch in linux-4.11-rc5.

I would suggest merging this addon patch on top of that bug fix to avoid
introducing a new warning in the stable kernels.

Fixes: 61b79e16c68d (ACPI: Fix incompatibility with mcount-based function graph tracing)
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/acpi/power.c