net_sched: fix order of queue length updates in qdisc_replace()
authorKonstantin Khlebnikov <khlebnikov@yandex-team.ru>
Sat, 19 Aug 2017 12:37:07 +0000 (15:37 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Aug 2017 08:19:21 +0000 (10:19 +0200)
commit58079f56b30227c37709e9db7e9b51204e81f4ea
tree34617a03b7b5a66a3ffa843b2a1f2308b14d359f
parent248af6aa226c5e3d503a26e109db944a1cabdb48
net_sched: fix order of queue length updates in qdisc_replace()

[ Upstream commit 68a66d149a8c78ec6720f268597302883e48e9fa ]

This important to call qdisc_tree_reduce_backlog() after changing queue
length. Parent qdisc should deactivate class in ->qlen_notify() called from
qdisc_tree_reduce_backlog() but this happens only if qdisc->q.qlen in zero.

Missed class deactivations leads to crashes/warnings at picking packets
from empty qdisc and corrupting state at reactivating this class in future.

Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Fixes: 86a7996cc8a0 ("net_sched: introduce qdisc_replace() helper")
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/net/sch_generic.h