net: dsa: fix preparation of a port STP update
authorVivien Didelot <vivien.didelot@savoirfairelinux.com>
Tue, 29 Sep 2015 18:17:54 +0000 (14:17 -0400)
committerDavid S. Miller <davem@davemloft.net>
Wed, 30 Sep 2015 04:36:01 +0000 (21:36 -0700)
commit57a47532c4312159935c98b7f1cf0e62296b9171
tree81b53ee9607a5f3f1536b08314bab337f8695012
parent9ae6d4935e3df35a23bbbe531c6b9ff314e7fd0f
net: dsa: fix preparation of a port STP update

Because of the default 0 value of ret in dsa_slave_port_attr_set, a
driver may return -EOPNOTSUPP from the commit phase of a STP state,
which triggers a WARN() from switchdev.

This happened on a 6185 switch which does not support hardware bridging.

Fixes: 3563606258cf ("switchdev: convert STP update to switchdev attr set")
Reported-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dsa/slave.c