projects / GitHub / moto-9609 / android_kernel_motorola_exynos9610.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 8c4343e) | patch
[media] cx25821: off by one in cx25821_vidioc_s_input()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 13 Oct 2011 05:41:41 +0000 (02:41 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 3 Nov 2011 20:33:55 +0000 (18:33 -0200)
commit567a23f4389f86c10355ae89909d6d87f312d1a0
tree2d9819a0995945ba4dbe0b7ef86f17cd411d53c6tree | snapshot (tar.gz zip)
parent8c4343e5909f956140229b0d960dc7a9c4fd4bddcommit | diff
[media] cx25821: off by one in cx25821_vidioc_s_input()

If "i" is 2 then when we call cx25821_video_mux() we'd end up going
past the end of the cx25821_boards[dev->board]->input[].

The INPUT() macro obfuscates what's going on in that function so it's
a bit hard to follow.  And as Mauro points out the hard coded 2 is
not very helpful.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/cx25821/cx25821-video.c diff | blob | blame | history
drivers/media/video/cx25821/cx25821.h diff | blob | blame | history